Merge pull request #539 from bhaktishh/main

Color changes for light color themes.
ejgallego · Sep 25, 2023 · b63e22d · b63e22d
2 parents a804b63 + de92ef3
commit b63e22d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -3,6 +3,7 @@
 
  - Update VSCode client dependencies, should bring some performance
    improvements to goal pretty printing (@ejgallego, #530)
+ - Update goal display colors for light mode so they are actually readable now. (@bhaktishh, #539, fixes #532)
  - Added link to Python coq-lsp client by Pedro Carrot and Nuno
    Saavedra (@Nfsaavedra, #536)
  - Properly concatenate warnings from _CoqProject (@ejgallego,

diff --git a/editor/code/views/info/media/coqpp.css b/editor/code/views/info/media/coqpp.css
@@ -64,10 +64,14 @@ div.Pp_box:not([data-mode="vertical"]) > .Pp_break:not(.br) > span.prev-indent {
   color: #aabb22;
 }
 
-.constr\.variable {
+body.vscode-dark .constr\.variable {
   color: #7fbfff;
 }
 
+body.vscode-light .constr\.variable {
+  color: #007bff;
+}
+
 .module\.definition {
   color: #777ddd;
 }
@@ -80,14 +84,22 @@ div.Pp_box:not([data-mode="vertical"]) > .Pp_break:not(.br) > span.prev-indent {
   color: #9674b8;
 }
 
-.tactic\.primitive {
+body.vscode-dark .tactic\.primitive {
   color: #c0c0c0;
 }
 
-.tactic\.string {
+body.vscode-light .tactic\.primitive {
+  color: #5c5b5b;
+}
+
+body.vscode-dark .tactic\.string {
   color: #99ff99;
 }
 
+body.vscode-light .tactic\.string {
+  color: #71ba71;
+}
+
 .constr\.reference:hover,
 .constr\.type:hover,
 .constr\.variable:hover,