Skip to content
This repository has been archived by the owner on Dec 13, 2024. It is now read-only.

Another attempt at d3 module bundling with webpack #7

Merged
merged 6 commits into from
Dec 2, 2018
Merged

Another attempt at d3 module bundling with webpack #7

merged 6 commits into from
Dec 2, 2018

Conversation

ejfox
Copy link
Owner

@ejfox ejfox commented Mar 5, 2018

still doesnt work tho

@ejfox
Copy link
Owner Author

ejfox commented Mar 5, 2018 •
edited
Loading

@bradoyler do you know any way to correctly bundle d3 modules with webpack? I feel so dumb

cc @enjalot

@ejfox
Copy link
Owner Author

ejfox commented Mar 5, 2018

@petulla do you know

@bradoyler
Copy link

bradoyler commented Mar 5, 2018 •
edited
Loading

the proper way to use d3-selection-multi with imports?
Looks like the proper pattern is:

import {selection, select} from "d3-selection";
import "d3-selection-multi";

@bradoyler
Copy link

bradoyler commented Mar 5, 2018 •
edited
Loading

This seems related to d3/d3-selection-multi#6
as d3-selection-multi doesn't actually export anything, it just overwrites the prototype for d3.select()

Also, you're not the only one: d3/d3-selection-multi#11

@ejfox ejfox merged commit cf7eac2 into master Dec 2, 2018
@ejfox ejfox deleted the new-webpack branch December 2, 2018 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejfox @bradoyler