Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider directory when extracting compilation target #6

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Consider directory when extracting compilation target #6

merged 1 commit into from
Oct 30, 2021

Conversation

ahojnnes
Copy link
Contributor

When generating compile_commands.json from CMake, some generated target may generate file paths in the following form:

{
  "directory": "/home/joschonb/dev/repo/build/...",
  "command": "/usr/bin/clang++-10 ...",
  "file": "/home/joschonb/dev/repo/build/.../src-file.cc"
},

This case, the existing logic to find the compilation target was broken. This fixes the issue.

@ejfitzgerald ejfitzgerald merged commit 66fa2f3 into ejfitzgerald:master Oct 30, 2021
mathstuf pushed a commit to mathstuf/clang-tidy-cache that referenced this pull request Jan 18, 2023
@kokulshan
Merge pull request ejfitzgerald#6 from aminya/export-fixes
13cdfab 
fix: fix null pointer dereference in export-fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejfitzgerald ejfitzgerald ejfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahojnnes @ejfitzgerald