add jac_normalized in setup parameter for jac and remove init flag from solve_eit,... #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hy @liubenyuan,
I saw that we forget the jac_normalized option for jac. is it also needed for greit? If yes I can added it!
By the way I just forget to ask you why you introduced the init flag on solve_eit, compute_b_matrix, compute_jac_matrix.
I think the init flag can be removed! each time you set it to true you pass a perm vector and viceversa, so it make it the flag redondant.
I would suggest we recalculate kg only when perm is not None. It is maybe more intuitive, I was confused by using it in my own sofware. I made made some modifications (which made fem even more lighter!)