Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never emit the GenerateShapeAttribute<T> into a user's assembly #111

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

AArnott
Copy link
Contributor

@AArnott AArnott commented Feb 3, 2025

It isn't necessary, since it only triggers source generation within the compilation of the code that applies it. It's also problematic because some runtimes (e.g. .NET Framework and unity) do not support generic attributes and reflection APIs throw when they encounter it.

It isn't necessary, since it only triggers source generation within the compilation of the code that applies it.
It's also problematic because some runtimes (e.g. .NET Framework and unity) do not support generic attributes and reflection APIs throw when they encounter it.
Copy link
Owner

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (7769d18) to head (e9860e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files         191      191           
  Lines       12138    12138           
  Branches     1585     1585           
=======================================
  Hits        11484    11484           
  Misses        652      652           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiriktsarpalis eiriktsarpalis merged commit e7d800e into eiriktsarpalis:main Feb 3, 2025
6 checks passed
@AArnott AArnott deleted the hideGenericAttribute branch February 3, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants