Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend marshaller support to generic types #105

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

eiriktsarpalis
Copy link
Owner

FYI @AArnott

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.60%. Comparing base (dc4f608) to head (a309d9e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../PolyType.SourceGenerator/Helpers/RoslynHelpers.cs 86.36% 3 Missing ⚠️
src/PolyType.Roslyn/Helpers/RoslynHelpers.cs 50.00% 1 Missing ⚠️
...yType.SourceGenerator/Parser/Parser.ModelMapper.cs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   94.62%   94.60%   -0.03%     
==========================================
  Files         189      189              
  Lines       11970    12006      +36     
  Branches     1562     1567       +5     
==========================================
+ Hits        11327    11358      +31     
- Misses        641      645       +4     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiriktsarpalis eiriktsarpalis merged commit 3f6df99 into main Jan 23, 2025
4 of 6 checks passed
@eiriktsarpalis eiriktsarpalis deleted the feature-typeshapefunc branch January 23, 2025 20:31
@AArnott
Copy link
Contributor

AArnott commented Jan 23, 2025

Awesome. And it appears no change is required in Nerdbank.MessagePack to support this aside from updating the PolyType version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants