Fix source generator including unused unsafe accessors (#75)

eiriktsarpalis · Dec 9, 2024 · bb13320 · bb13320
1 parent a6f44fa
commit bb13320
Showing 1 changed file with 20 additions and 2 deletions.
diff --git a/src/PolyType.SourceGenerator/SourceFormatter/SourceFormatter.Object.cs b/src/PolyType.SourceGenerator/SourceFormatter/SourceFormatter.Object.cs
@@ -59,12 +59,30 @@ private static void FormatMemberAccessors(SourceWriter writer, ObjectShapeModel
                     FormatPropertyGetterAccessor(writer, objectShapeModel, property);
                 }
 
-                if (property is { EmitSetter: true, IsSetterAccessible: false } || 
-                    (objectShapeModel.Constructor is not null && property.IsInitOnly))
+                if ((!property.IsSetterAccessible || property.IsInitOnly) && 
+                    (property.EmitSetter || IsUsedByConstructor(property)))
                 {
                     writer.WriteLine();
                     FormatPropertySetterAccessor(writer, objectShapeModel, property);
                 }
+
+                bool IsUsedByConstructor(PropertyShapeModel property)
+                {
+                    if (objectShapeModel.Constructor is not {} ctor)
+                    {
+                        return false;
+                    }
+
+                    foreach (var parameter in ctor.RequiredMembers.Concat(ctor.OptionalMembers))
+                    {
+                        if (parameter.Name == property.Name)
+                        {
+                            return true;
+                        }
+                    }
+
+                    return false;
+                }
             }
         }