-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(types): Add Blob::index field introduced in celestia 0.13 #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 left some suggestions
could you look into the CI failures too? |
some of the failures seems to be coming from toolchain updates, I'll look into that tomorrow |
I have a fix for clippy and docs failures in #275. Unfortunately the rest of Lumina team is off-site, so if I won't find any reviewer, this will have to wait till Thursday. I think those test failures are related to this change tho https://github.com/eigerco/lumina/actions/runs/8976014314/job/24653654722?pr=274 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for the contribution! 🎸
@S1nus I've just noticed that the commits aren't signed |
Hey @S1nus, I took closer look on why do the tests fail. Hope you didn't mind my interference 🙏 So it turned out that the index field is always set when making requests using
|
this also makes sure that binary serializers will always serialize / deserialize the same type, this isn't issue in case of jsons, but could be for other like bincode or risc0 |
@fl0rek I set up signing, newer commits are signed. is it good? or need to do something else? |
Co-authored-by: c-node <[email protected]> Co-authored-by: c-node <[email protected]>
Previous commits needed to be signed too, but I just squashed them and it looks fine. I've added the fix for celestia-rpc tests, hopefully CI will be happy now |
Another attempt at adding this field. Now, trying to use an
Option<u64>
.