Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a client for sending internal events #47

Closed

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

eiffel-community/etos-api#91

Description of the Change

This is the client that should be used together with the SSE v2 server
Also updated the rabbitmq log handler to send using this client instead
The logger will now publish all logs, not only user logs. In the ETOS client we will filter away all logs that are on the debug level, so this should eventually be fine.
This change requires the log_listener to be updated to support RabbitMQ streams when running ETOS v0.

Alternate Designs

I want etosV0 to still work, but this change will break it until the log listener in the suite runner repository is updated.
The complexity in this change would be higher than I would like if we were to support both ways.

Possible Drawbacks

The new RabbitMQ library used here is unproven in an ETOS environment and I suspect we will see a few issues with it. I could not find a way to get pika to do this for us.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

This is the client that should be used together with the SSE v2 server
Also updated the rabbitmq log handler to send using this client instead
The logger will now publish all logs, not only user logs.
@t-persson t-persson requested a review from a team as a code owner February 27, 2025 11:01
@t-persson t-persson requested review from fredjn and andmat900 and removed request for a team February 27, 2025 11:01
@t-persson t-persson closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant