Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set routing key to None in eiffellib #11

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

N/A

Description of the Change

Update to latest eiffellib and set routing_key to None.
Also add an optional domain_id to constructor.
This change cannot be merged until eiffel-community/eiffel-pythonlib#37 is merged

Alternate Designs

Eiffellib updated, we should always follow eiffellib. No other alternative was considered.

Benefits

This change adds routing keys to events.

Possible Drawbacks

None

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

Update to latest eiffellib and set routing_key to None
@t-persson t-persson requested a review from a team as a code owner September 30, 2021 09:32
@t-persson t-persson requested review from fredjn and andjoe-axis and removed request for a team September 30, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants