Added schemas for Activity events. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partial resolution of issue #33. |
Also fixed errors in EiffelActivityFinishedEvent example, discovered when applying the schema.
d-stahl-ericsson
force-pushed
the
topic-drop3-schema-activity
branch
from
50714f8 to
b1c475a
Compare
| "additionalProperties": false | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Shouldn't outcome be required?
There was a problem hiding this comment.
Of course it should :)
Fixed.
|
To make the Activity events complete we need a schema for EiffelActivityCanceledEvent as well. |
|
The PR already includes a schema for EiffelActivityCanceledEvent? |
|
I can see it now. Then I have no further comments on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed errors in EiffelActivityFinishedEvent example, discovered when applying the schema.