-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testCase version to TERCC batches #286
Add testCase version to TERCC batches #286
Conversation
I believe you mean EiffelTestCaseTriggeredEvent and not EiffelActivityTriggeredEvent? |
Correct. I have changed it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 4.2.0 version should be added to the version history in the md file
I added it, but did not know what to do with "Introduced in". Asked a question on slack about that. |
This was somehow discussed when releasing the Lyon edition in #277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown trickyness
eiffel-vocabulary/EiffelTestExecutionRecipeCollectionCreatedEvent.md
Outdated
Show resolved
Hide resolved
…ent.md Co-authored-by: Mattias Linnér <[email protected]>
I will merge this as it is written by one of the maintainers (Tobias) and approved by me (maintainer) and a second TC member (Mattias). |
* Add testCase version to TERCC batches * Update eiffel-vocabulary/EiffelTestExecutionRecipeCollectionCreatedEvent.md Co-authored-by: Mattias Linnér <[email protected]>
Applicable Issues
fixes: #288
Description of the Change
The
data.testCase
object in EiffelTestCaseTriggeredEvent share the same parameters as the TERCC except forversion
.This change adds that
version
string to thedata.batches.recipes.testCase
object in the TERCC.Alternate Designs
It's a bit weird that we have this information duplicated between two events, but I can see the appeal of having it and easier being able to match what's in the TERCC and what has actually been triggered so I think the duplication still serves a purpose.
Benefits
ETOS uses TERCCs for knowing what to test and if ETOS also knows which versions of the tests to use, then that's a bit benefit when implementing features such as "replay" (where we can replay the entire ETOS run).
Possible Drawbacks
Duplication between these events might be a problem when we forget to update.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]