Add SCC as valid ELEMENT target in CD #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-hallen-ericsson
previously approved these changes
May 7, 2020
| }, | ||
| "version": { | ||
| "type": "string", | ||
| "enum": [ "3.0.0" ], |
There was a problem hiding this comment.
Should this also be updated to be 3.1.0?
There was a problem hiding this comment.
Yes it should. Thanks for noting!
e-pettersson-ericsson
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Resolves #218
Description of the Change
EiffelCompositionDefinedEvent can have an ELEMENT link pointing at an EiffelSourceChangeSubmittedEvent. This is a natural fit for post-merge/production pipelines, but not for pre-merge/review pipelines. This change introduces the possibility to link EiffelCompositionDefinedEvent to EiffelSourceChangeCreatedEvent using an ELEMENT link.
Alternate Designs
Benefits
To gain traceability using compositions also in pre-merge pipelines
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Emil Bäckmark [email protected]