-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added data.testCase.version to EiffelTestCaseStartedEvent #126
Added data.testCase.version to EiffelTestCaseStartedEvent #126
Conversation
#### data.testCase.uri | ||
__Type:__ String | ||
__Required:__ No | ||
__Description:__ A location where a description of the test case can be retrieved. | ||
__Description:__ A location where a description of the test case can be retrieved. Whether the uri includes the version of the test case or just its id is up to the user of the protocol to decide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with this. We should state that the actual test case executed SHALL be uniquely and unambiguously identifiable, e.g. "To the extent that multiple versions of the same test case co-exist, the URI SHALL identify the exact version executed."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Fair enough.
#### data.testCase.version | ||
__Type:__ String | ||
__Required:__ No | ||
__Description:__ The unique version of the executed test case identity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps append that "Where this property is not used it is assumed that test cases are not version controlled."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
As per issue #119