Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowner file and update checklist #11

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

henning-roos
Copy link
Member

Applicable Issues

eiffel-community/community#7

Description of the Change

Since we have decided that repositories should have code owner files for automatically adding reviewers etc. the repository-template must reflect this decision.

Alternate Designs

Benefits

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Henning Roos [email protected]

@henning-roos henning-roos requested a review from a team September 29, 2020 07:37
Copy link
Member

@fredjn fredjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@m-linner-ericsson m-linner-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

@raja-maragani raja-maragani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fredjn
Copy link
Member

fredjn commented Oct 7, 2020

@eiffel-community/eiffel-community-maintainers - let's get this on in the bag, 22 days and counting.....

@henning-roos henning-roos merged commit 085d97e into eiffel-community:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants