Update rabbitmq_publisher.py #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use current_thread().name instead of current_thread().getName() to remove deprecation warning.
ebram96
requested review from
t-persson and
fredjn
and removed request for
a team
|
Changes look fine, thank you for contributing. However, I am curious to know why the PR template is not used. Was it ignored/removed deliberately, or it there is there something broken with the template propagation from the eiffel-community organization? |
|
PR templates aren't used if you edit files directly from the GitHub web page. |
|
@fredjn @magnusbaeck I think I deliberately skipped using the template in this PR. Why ? I thought it's a really tiny change and I didn't want reviewers going through the template for such a change. I can -for sure- update the PR with the template contents if you want me to. |
|
@fredjn @magnusbaeck I updated the PR. |
fredjn
approved these changes
Nov 8, 2022
t-persson
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
NA.
Description of the Change
Use current_thread().name instead of current_thread().getName() to remove deprecation warning.
Alternate Designs
NA.
Benefits
Use current_thread().name instead of current_thread().getName() to remove deprecation warning.
Possible Drawbacks
NA
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Ebram Shehata [email protected]