Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sleep to re-sending nacked events #48

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

fixes: #47

Description of the Change

Add a sleep when re-sending NACKed events.

Alternate Designs

Since the issue is that events are not being sent, we could reduce the size of the list so that we only ever re-send a few events each iteration. This would also reduce the CPU usage, but it would add complexity that I want to avoid if possible.

Benefits

The machines running the library will not use 100% CPU when re-sending nacked events.

Possible Drawbacks

It will make the library slower.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

@t-persson t-persson requested a review from a team as a code owner February 23, 2022 09:00
@t-persson t-persson requested review from fredjn and removed request for a team February 23, 2022 09:00
@t-persson t-persson merged commit 5094311 into eiffel-community:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lot's of CPU usage when re-sending many nacked events
2 participants