MAINT: remove hard coded event type class name. #46
Conversation
EmanIsmail
requested review from
t-persson and
fredjn
and removed request for
a team
|
Thank you for this pull request! In your description of this pull request you can add Secondly, please write your full name and email in the Thank you! |
There was a problem hiding this comment.
Looks good.
I added a comment that you do not need to fix. We'll discuss this between maintainers. Might be that have to make a change when we've discussed it.
One more thing: You'll need to update the licenses at the top of each file as per: https://github.com/eiffel-community/.github/blob/master/CONTRIBUTING.md#license-management
In other words. Update to: Copyright 2019-2022 Axis Communications AB and others. at the very top :)
| @@ -174,7 +174,7 @@ class EiffelBaseEvent(object): | |||
| tag = "_" | |||
| domain_id = "_" | |||
| version = "0.0.1" | |||
| meta = EiffelBaseMeta("EiffelBaseEvent", version) | |||
| meta = EiffelBaseMeta(__qualname__, version) | |||
There was a problem hiding this comment.
__qualname__ will break our python2 compatibility, which can be considered fine if we do a major tag update.
But we will have to discuss whether or not we are okay with this first.
There was a problem hiding this comment.
I'd be fine with doing a major version step and effectively leaving python 2.x behind, although I think we need to hold of and provide any potential users with a deprecation notice/period. What I'm reluctant to do is to maintain both a python 2.x and a python 3.x versions, but that is mostly common sense given the EOL of Python 2.x.
|
We've discussed this and it will be released in a major tag update. Thank you for your contribution |
Applicable Issues
fixes: #45
Description of the Change
Replace using hard coded event type class name with the builtin attribute
__class__.__name__or__qualname__.Alternate Designs
N/A
Benefits
Easier maintenance in case changing
Possible Drawbacks
N/A
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Eman Ismail [email protected]