Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method for waiting for unpublished events #42

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

fixes: #41

Description of the Change

This was triggered due to a documentation error in the README plus the fact that we are seeing this issue ourselves.
Basically there was no way to check that events have been published to the broker before exiting the publisher.
This change adds a method for waiting for unpublished events.

Alternate Designs

We could open up the _deliveries and _nacked_deliveries so the users can create their own wait methods, but I feel that this should be a feature in the library.
We could also add this as a step when shutting down the publisher, but I decided against it due to it being a bigger change for users.

Benefits

This will allow users to wait for broker ACK before exiting when publishing events

Possible Drawbacks

None that I can see

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

Also update the README to reflect this update.
@t-persson t-persson requested a review from a team as a code owner January 11, 2022 13:56
@t-persson t-persson requested review from fredjn and removed request for a team January 11, 2022 13:56
@t-persson t-persson merged commit 4fc0560 into eiffel-community:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in examples of README
2 participants