Update event schemas to edition-lyon #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
magnusbaeck
and removed request for
a team
magnusbaeck
approved these changes
Oct 29, 2021
fredjn
approved these changes
Oct 29, 2021
Comment on lines
+74
to
+88
| def _latest_schema(self, base_path): | ||
| """Find the latest schema file in path. | ||
|
|
||
| :param base_path: The base path of the events schemas. | ||
| :type base_path: str | ||
| :return: The latest version found in path. | ||
| :rtype: :obj:`packagin.version.Version` | ||
| """ | ||
| latest = None | ||
| for path in glob.glob("%s/*.json" % base_path): | ||
| name = path.split("/")[-1] | ||
| version = parse(name.replace(".json", "")) | ||
| if latest is None or version > latest: | ||
| latest = version | ||
| return latest |
There was a problem hiding this comment.
Wouldn't it be more robust to read the version from the schema and not be dependent a particular filename?
There was a problem hiding this comment.
Probably, but the eiffellib uses the filenames for versioning so we have to test it the same way.
If we want to change it in the library, then we should write an issue on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
fixes: #39
Description of the Change
The eiffel protocol has updated. Update eiffellib to follow the latest.
Also set all default versions in the event classes to the the latest eiffel spec.
Added tests that make sure that a version that exists is used as default and that the default is the latest event version.
Note that I added a tox.ini file, but updating the whole repository in this change seemed bad.
I will make another PR where black, pylint and pydocstyle are happy.
Alternate Designs
Updating this library every time that we have a new edition is a small pain, but I didn't want to dabble in auto updates right now. We should follow the same design as eiffel-go-sdk in the future.
Benefits
Latest and greatest
Possible Drawbacks
None!
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]