Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring fixed version numbers for requirements makes it hard to
impossible to use eiffellib in certain circumstances. Libraries should
always declare as open dependencies as possible to allow some
flexibility for the clients.
Should a client not want to allow for this flexibility they can always
use a constraints.txt (pip) or poetry.lock (poetry) to lock down the
version numbers for any transient dependencies. The other way around is
impossible, i.e allow a less restrictive version requirement and the
declared requirement from the package.
Increasing the jsonschema from an alpha version to the actual release
resolves #34. Requiring an alpha release when the actual release was
finalized over two years ago is sort of wicked.
Applicable Issues
#34
Description of the Change
Allow for versions of our dependencies to be higher than the given requirement as long as they are of the same major version.
Alternate Designs
N/A
Benefits
Users of eiffellib can use python > 3.7
Reduce the risk of an impossible version situation for our users.
Possible Drawbacks
Our users might get dependencies from projects that does not adhere to semver (i.e broken non major versions).
This is commonly mitigated with a constraints.txt when using pip or a poetry.lock when using poetry.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Martin Wallgren [email protected]