Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify open dependencies #35

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

MartinWallgren
Copy link
Contributor

@MartinWallgren MartinWallgren commented Jun 10, 2021

Declaring fixed version numbers for requirements makes it hard to
impossible to use eiffellib in certain circumstances. Libraries should
always declare as open dependencies as possible to allow some
flexibility for the clients.

Should a client not want to allow for this flexibility they can always
use a constraints.txt (pip) or poetry.lock (poetry) to lock down the
version numbers for any transient dependencies. The other way around is
impossible, i.e allow a less restrictive version requirement and the
declared requirement from the package.

Increasing the jsonschema from an alpha version to the actual release
resolves #34. Requiring an alpha release when the actual release was
finalized over two years ago is sort of wicked.

Applicable Issues

#34

Description of the Change

Allow for versions of our dependencies to be higher than the given requirement as long as they are of the same major version.

Alternate Designs

N/A

Benefits

Users of eiffellib can use python > 3.7
Reduce the risk of an impossible version situation for our users.

Possible Drawbacks

Our users might get dependencies from projects that does not adhere to semver (i.e broken non major versions).
This is commonly mitigated with a constraints.txt when using pip or a poetry.lock when using poetry.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Martin Wallgren [email protected]

Declaring fixed version numbers for requirements makes it hard to
impossible to use eiffellib in certain circumstances. Libraries should
always declare as open dependencies as possible to allow some
flexibility for the clients.

Should a client not want to allow for this flexibility they can always
use a constraints.txt (pip) or poetry.lock (poetry) to lock down the
version numbers for any transient dependencies. The other way around is
impossible, i.e allow a less restrictive version requirement and the
declared requirement from the package.

Increasing the jsonschema from an alpha version to the actual release
resolves eiffel-community#34. Requiring an alpha release when the actual release was
finalized over two years ago is sort of wicked.
@MartinWallgren MartinWallgren requested a review from a team as a code owner June 10, 2021 11:33
@MartinWallgren MartinWallgren requested review from t-persson and fredjn and removed request for a team June 10, 2021 11:33
@magnusbaeck
Copy link
Member

Signed-off-by: Martin Wallgren [email protected]

maritn?

@MartinWallgren
Copy link
Contributor Author

Signed-off-by: Martin Wallgren [email protected]

maritn?

Sigh, thank you.

@fredjn
Copy link
Member

fredjn commented Jun 10, 2021

The PR is all good (Thank you!) but a kind of funny (and scary) side note, ETOS uses eiffel-pythonlib, and ETOS runs on Python 3.9.x. I guess we've been lucky with that so far. =)

@t-persson t-persson merged commit 061ba95 into eiffel-community:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsonschema == 3.0.0a2 is not compatible with python 3.8 and above
4 participants