New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ehrbase#753: node ids null and annotations missing #343

Merged

stefanspiska merged 3 commits into develop from 753-web-template-missing-some-nodeids-and-annotations

Mar 28, 2022

Contributor

mhenke-vg commented Mar 24, 2022

Adds annotations getting written to the node specified by path
Annotations and NodeIds of Elements properly get passed down to children


          fix ehrbase#753: node ids null and annotations missing

d1c0327

mhenke-vg requested a review from stefanspiska

March 24, 2022 15:38

stefanspiska requested changes

View reviewed changes

Contributor

stefanspiska left a comment •

edited

Loading

Also please update the cahngelog.md

...ata/src/main/java/org/ehrbase/test_data/operationaltemplate/OperationalTemplateTestData.java Outdated

@@ @@ -112,7 +112,8 @@ @@
                 RE_SPECT("ReSPECT-3.v0", "ReSPECT-3.v0.opt", "ReSPECT-3.v0"),
                 IPS("International Patient Summary", "ips.v0.opt", "International Patient Summary"),
                 ERROR_TEST("Contains choice between interval and not interval", "ErrorTest.opt", "ErrorTest"),
-                SECTION_CARDINALITY("Cardinality test template sections", "section_cardinality.opt", "cardinality_of_section");
+                SECTION_CARDINALITY("Cardinality test template sections", "section_cardinality.opt", "cardinality_of_section"),
+                NULLID("My Nullid test", "nullid.opt", "nullid");

Contributor

stefanspiska Mar 25, 2022

The templateid "nullid" is wrong this is way the test are failing

mhenke-vg added 2 commits

March 28, 2022 10:16


          fix tests


          Merge branch 'develop' into 753-web-template-missing-some-nodeids-and…

74f3ccd

…-annotations

sonarqubecloud bot commented Mar 28, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

97.6% Coverage
0.0% Duplication

stefanspiska approved these changes

View reviewed changes

stefanspiska merged commit 54b548c into develop

stefanspiska deleted the 753-web-template-missing-some-nodeids-and-annotations branch

March 28, 2022 09:34

stefanspiska mentioned this pull request

Web template missing some nodeIds and annotations ehrbase/ehrbase#753

Closed

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet