Validate the value set

[skounis]

Setup an action that validates the valuesets.

It fetches the valueset.json and validates all the .json files

[gabywh]

1. No need to fetch: valueset.json should now be included in this repo.
2. However, this does NOT validate the valueset as such, only the JSON structure.
3. If you want to simply validate the JSON structure, then sure use e.g. ajv with valueset.json as schema defn. Any decent text editor would, however, almost certainly have flagged any JSON structural inconsistencies, so the value of this step is debatable - particularly as it may generate a false sense of security with people thinking it is all good when the reality is that it only checks if you have matched the { } plus a little more...

[skounis]

I'm a bit confused. Why we keep the valueset.json which is the schema in this repo instead of keeping it in the repository where we maintain all the schemas? No that technically makes any difference. We should however keep this file in just one place.

What it validates is if the JSON is well structured and also if the required properties are there and spelled correctly. A developer could do this in the editor but we do not have any control on what will be committed. We all do mistakes. For example:

Wrongly spelled property

Missing property

[gabywh]

"A developer could do this in the editor but we do not have any control on what will be committed" Not sure I understood this... Onl a handful of people should be generating valuesets - and even that should have been completely automated by now, but I see it isn't. Further, for end users, there should be provided a SHA256 together with the valuesets, which should all have been available as world-real from an EU DCC GW endpoint, which is also not yet implemented, I see. For sure value is there for catching spelling mistakes etc, is only useful for a small group of people (but useful nevertheless, I agree) whereas implementing the SHA256 would be much more useful to everyone world-wide. My vote is to prioritize the latter, but since I am no longer working on this since 2021-07-31 then whoever is running this needs to pick it up.

…

On okt. 12 2021, at 1:36 pm, Stavros Kounis ***@***.***> wrote: I'm a bit confused. Why we keep the valueset.json which is the schema in this repo instead of keeping it in the repository we maintain the schemas? No that technically makes any difference. We should however keep this file in just one place. What it validates is if the JSON is well structured and also the if the required properties are there and spelled correctly. A developer could do this in the editor but we do not have any control on what will be committed. We all do mistakes. For example: Wrongly spelled property Missing property — You are receiving this because you commented. Reply to this email directly, view it on GitHub (#9 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ASHCPHN6TMNLGXXORTNAAIDUGQMT7ANCNFSM5ANJ7QKA). Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).

-- Deze e-mail is gecontroleerd op virussen door AVG. http://www.avg.com

[dslmeinte]

It seems this change is also part of PR #26 : can we just look at that PR, or do you want to merge these changes (“automically”) in stages, @skounis ?