Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Focus Mode #11

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: added Focus Mode #11

wants to merge 19 commits into from

Conversation

egonl
Copy link
Owner

@egonl egonl commented Apr 10, 2024

When Focus Mode is enabled, Portion of Screen will automatically position itself over the currently focused window.

Focus Mode can be enabled in the Options dialog, which is available in the System Menu.

@egonl egonl mentioned this pull request Apr 10, 2024
@dodjango
Copy link

following the focus ✅
resizing the focused window ✅
multi monitor, different scaling ❌
ignoring very small window size ✅

@dodjango
Copy link

⚠️ right click to open the options does not work. If you like, see this commit: dodjango@6cccc17

@egonl
Copy link
Owner Author

egonl commented Apr 12, 2024

Right click isn't needed anymore, as there's now an Options menu:
image

@dodjango
Copy link

The PR description still says right click, therefore I mentioned it.

@egonl egonl changed the title feat: added Follow Mode feat: added Focus Mode Apr 12, 2024
@egonl
Copy link
Owner Author

egonl commented Apr 12, 2024

Updated description. I'm struggling with the scaling issue atm.

@Bzly
Copy link

Bzly commented Apr 29, 2024

Some thoughts on how this is working so far:

  • I actually preferred the 'snappier' behaviour prior to #b466034
  • Perhaps a special exception for the Alt-Tab and Win-Tab windows switchers, for privacy (these are shared along with general desktop when active) - could share a 1x1 black rectangle (or 0x0 if possible?), or some kind of privacy placeholder, or blur/pixelate instead.
  • When the window border extends behind the task bar, the task bar is shown. It would be good if there was a check for window pos extending below taskbar height, and if so only drawing to there instead of screen edge.
  • Can AUTO_REMOVE_CAPTION trigger based on whether PortionOfScreen is focused or not, rather than a timer?

It is working though, and I'm already looking forward to how much less frustrating meetings will be. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants