Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operating system support (DragonFly BSD) #606

Merged
merged 6 commits into from
Sep 16, 2018

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Sep 3, 2018

Found by: michaelortmann
Patch by: michaelortmann
Fixes: Part of #176

One-line summary:
Enhance "DragonFly BSD" support, switched default build from static to shared

Additional description (if needed):
This patch is based on
https://raw.githubusercontent.com/DragonFlyBSD/DPorts/master/irc/eggdrop/dragonfly/patch-configure
and enhances "DragonFly BSD" support and *BSD Support in general
there was a wildcard *BSD in aclocal.m4
which may match too many *BSD and the same time doesnt match DragonFly
this patch replaces this wildcard with proper Names
this patch also enhances doc for dragonfly bsd
this patch also rips out support for BSD/OS (originally called BSD/386 and sometimes known as BSDi) because Wind River discontinued sales of BSD/OS at the end of 2003, with support terminated at the end of 2004."

I also tested eggdrop on TrueOS and it worked out of the box, because its only a minimal modified FreeBSD. If there is any official list of supported/tested operating systems for eggdrop besides "any c89/posix2001 should work", we could add DragonFly and TrueOS now, but i didnt find such a list. But what i found was doc/BUG-REPORT and i updated it.,

when merging, please run misc/runautotools

Test cases demonstrating functionality (if applicable):

The following test was done on "DragonFly BSD" 5.2.2:

before:

./configure

[...]
WARNING:

  The operating system you are using has not yet had a great
  deal of testing with Eggdrop. For this reason, this compile
  will default to "make static".

  To enable module support, type "make eggdrop" instead of just
  "make" after you run "make config" (or "make iconfig").

  As we have not done a sufficient amount of testing on this
  OS, your feedback is greatly appreciated. Please let us know
  at [email protected] if there are any problems compiling with
  module support, or if you got it to work :)
[...]

after:

./configure
make config
make
make install
./eggdrop -nt

[...]
Hey -HQ!  My name is dragonflybsd and I am running eggdrop v1.8.3+acupdates, on DragonFly 5.2-RELEASE.
[...]

@michaelortmann michaelortmann changed the title (Fix part of #176) Enhance DragonFlyBSD support (Fix part of #176) Enhance "DragonFly BSD" support Sep 4, 2018
@michaelortmann michaelortmann changed the title (Fix part of #176) Enhance "DragonFly BSD" support Enhance "DragonFly BSD" support Sep 4, 2018
…nown as BSDi) because Wind River discontinued sales of BSD/OS at the end of 2003, with support terminated at the end of 2004.
@michaelortmann michaelortmann changed the title Enhance "DragonFly BSD" support Update operating system support (DragonFly BSD) Sep 4, 2018
Copy link
Member

@thommey thommey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, until someone complains :)

@vanosg vanosg merged commit 309be07 into eggheads:develop Sep 16, 2018
@michaelortmann michaelortmann deleted the dragonfly branch September 16, 2018 21:39
@Cizzle Cizzle added this to the v1.8.4 milestone Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants