Fix Darwin / macOS make error / dynamic module loading #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: barracuda156
Patch by: michaelortmann
Fixes: #1662
One-line summary:
Use the usual dlopen method, if darwin version >= 9 with native dlopen
Additional description (if needed):
run
misc/runautotoolswhen merging (andmisc/runautotools -fwhen testing this PR)Also for darwin >= 9 switched default built type from static to dynamic and dropped the
WEIRD_OSmarkAlso removed dead old code:
eggdrop/aclocal.m4
Lines 628 to 630 in 028e756
rld was overwritten with dyld all the time
also rld is kinda pre posix 2001
Test cases demonstrating functionality (if applicable):
I tested on
Darwin michaels-iMac-Pro.local 22.6.0 Darwin Kernel Version 22.6.0: Thu Dec 5 23:45:11 PST 2024; root:xnu-8796.141.3.709.7~4/RELEASE_X86_64 x86_64which is macOS Ventura 13.7.3
make eggdropto test dynamic loading of modules successfully.