(Cleanup) Cygwin: Eggdrop does not need FreeConsole() anymore #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelortmann
changed the title
michaelortmann
changed the title
michaelortmann
changed the title
|
cygwin console is fine, but cmd.exe hangs after: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: Travis Howell
Patch by: Travis Howell
Fixes: part of #176
One-line summary:
Eggdrop does not need FreeConsole() anymore
Additional description (if needed):
Windrop used that patch. I think they used it, because some time ago, the
FreeConsole()behaviour in Cygwin was broken. Now it compiles and runs fine, but as i tested below, it works the same with and withoutFreeConsole(). So why not clean that old legacy code up.Original patch here:
http://lists.eggheads.org/pipermail/patches/2001-March/000897.html
http://windrop.sourceforge.net/patches/eggdrop1.8.0.patch
Test cases demonstrating functionality (if applicable):
I tested with and without FreeConsole() executed under eggdrops background mode under Cygwin 2.11.1 under Windows 7 with gcc 7.3.0. No difference. OK.