Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playerItems) : no wool if conds not met #53

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from
+21 −5
Open

fix(playerItems) : no wool if conds not met #53

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99a3fa6
fix(playerItems) : no wool if conds not met
Mathu-lmn Jun 23, 2024
58dee0a
Merge branch 'stable' into dev
Mathu-lmn Jun 23, 2024
15c70b7
fix: death event for specs
JiveOff Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/fr/efreicraft/ludos/core/players/LobbyPlayerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public static void preparePlayerForLobby(LudosPlayer player) {
public static void preparePlayerItems(LudosPlayer player) {
List<MenuItem> items = new ArrayList<>();

if(Core.get().getTeamManager().getTeams().size() > 2) {
if(Core.get().getTeamManager().getTeams().size() > 2 && Core.get().getGameManager().isAutoGameStart() && Core.get().getGameManager().getDefaultGamePluginName() != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment ça isAutoGameStart? On devrait pouvoir donner une wool si on set un jeu ne démarrant pas automatiquement

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Car si autoGameStart est false, le jeu actuel ne restart pas et donc pas de choix de teams non ?

Copy link
Member

@JiveOff JiveOff Jun 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui mais si je fais un /game load LudosArena & que le jeu ne doit pas démarrer automatiquement, les joueurs doivent pouvoir recevoir une wool

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oui j'avais pas pensé à cette situation. Soit on remove cette condition soit on mets une sorte de paramètre dans la fonction qui donne l'information si on "force" le give

Copy link
Member

@JiveOff JiveOff Jun 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense qu'il faudrait vérifier pourquoi il y a + de deux teams d'enregistré s'il n'y a aucun jeu de chargé, il faut voir si on cleanup bien les teams avant d'envoyer les joueurs sur le lobby

items.add(
new ItemStackMenuItem(
0,
Expand Down
Loading