Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: multiple pnr corners, custom rc values #591

Merged
merged 32 commits into from
Feb 10, 2025
Merged

feat!: multiple pnr corners, custom rc values #591

merged 32 commits into from
Feb 10, 2025

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Oct 22, 2024 •
edited by donn
Loading

@openlane-bot
Copy link
Collaborator

openlane-bot commented Oct 22, 2024 •
edited
Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/eef7b95141784cae7d284fda404606a1

@kareefardi
++
b8170b3
@kareefardi
Add vias_rc
9dae522 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
skip if not defined
94ed573 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
fix default behavior
fd2e140 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
format
b6960db 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
Squashed commit of the following:
58bafed 
commit e7a0e71
Author: Kareem Farid <[email protected]>
Date:   Sun Nov 3 13:22:53 2024 +0200

    lint

    Signed-off-by: Kareem Farid <[email protected]>

commit 9e25b72
Author: Kareem Farid <[email protected]>
Date:   Sun Nov 3 13:11:51 2024 +0200

    update changelog, Verilator.Lint, Yosys.JsonHeader

    Signed-off-by: Kareem Farid <[email protected]>

commit 36bca9b
Author: Kareem Farid <[email protected]>
Date:   Sun Nov 3 12:52:59 2024 +0200

    bugfix: allow unsetting variables in configuration files

    Signed-off-by: Kareem Farid <[email protected]>

commit b0246e6
Author: Kareem Farid <[email protected]>
Date:   Tue Oct 29 15:29:20 2024 +0300

    hotfix: incorrect error message when substiuting with a nonexistent step

commit 19109e1
Author: Mohamed Gaber <[email protected]>
Date:   Sat Oct 26 20:12:12 2024 +0300

    bugfix: odb steps dropping PYTHONPATH (#592)

    * `Odb.*`
      * Fixed OpenROAD dropping user-set `PYTHONPATH` values.

    ## Tool Updates

    * Use `NIX_PYTHONPATH` instead of `PYTHONPATH` in Docker and devshells
      to avoid collisions with user-set `PYTHONPATH` variables.

commit 627a5ab
Author: Mohamed Gaber <[email protected]>
Date:   Thu Oct 24 11:03:55 2024 +0300

    nix: make flake.createOpenLane shell more ergonomic

    ## Tool Updates
    * `flake.createOpenLaneShell` now gets OpenLane from `python3.pkgs`.
    * Fixed issue with `flake.createOpenLaneShell` where plugins would not get
      included due to an operator precedence issue.

commit 8451508
Author: Mohamed Gaber <[email protected]>
Date:   Thu Oct 24 10:57:58 2024 +0300

    hotfix: regression in nix/create-shell.nix

commit 1bfa43d
Author: Mohamed Gaber <[email protected]>
Date:   Mon Oct 21 21:05:05 2024 +0300

    Temporarily revert Colab's OpenLane version until it's fixed

Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
Merge branch 'dev' into pnr-corners
a42904a
@kareefardi
Copy link
Collaborator Author

kareefardi commented Nov 25, 2024 •
edited
Loading

Blocked on: The-OpenROAD-Project/OpenROAD#6175 and The-OpenROAD-Project/OpenROAD-flow-scripts#2593

@kareefardi
Merge remote-tracking branch 'origin/dev' into pnr-corners
f4bad2f
@kareefardi
remove -corners in set_wire_rc
87c197a 
update sky130 via rc values

Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
try multiple PNR_CORNERS
f4cacb4 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
enable sky130 multiple PNR_CORNERS
d4ca1ab 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
restore defaults
fc9903d 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
Merge remote-tracking branch 'origin/dev' into pnr-corners
0af48c2 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
Merge remote-tracking branch 'origin/dev' into pnr-corners
1084a7a 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
Merge remote-tracking branch 'origin/dev' into pnr-corners
50ce550
@kareefardi
rename VIAS_RC to VIAS_R
8b23793 
update documentation to add units of LAYERS_RC and VIAS_R
remove default value for PNR_CORNERS

Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
add license information
686dc0b 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
update changelog
fd9cb95 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi kareefardi marked this pull request as ready for review January 19, 2025 14:34
@kareefardi kareefardi changed the title feat!: Read multi corner libs during PNR steps feat!: Multiple PNR corners and custom RC values Jan 19, 2025
kareefardi and others added 5 commits January 21, 2025 11:31
@donn donn changed the title feat!: Multiple PNR corners and custom RC values feat!: multiple pnr corners, custom RC values Feb 9, 2025
@donn donn changed the title feat!: multiple pnr corners, custom RC values feat!: multiple pnr corners, custom rc values Feb 9, 2025
donn
donn approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@donn donn merged commit 634c9b9 into dev Feb 10, 2025
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kareefardi @openlane-bot @donn