-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breadcrumbs pattern #334
Conversation
By analyzing the blame information on this pull request, we identified @andy-armstrong, @talbs and @clrux to be potential reviewers |
@@ -33,7 +33,7 @@ | |||
"css-loader": "~0.23.1", | |||
"browser-sync": "*", | |||
"del": "*", | |||
"edx-ui-toolkit": "~0.10.0", | |||
"edx-ui-toolkit": "git://github.com/edx/edx-ui-toolkit#bf34f8e6b0028b90c07536bd7279325ed6c3fa86", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: don't merge until this can be changed to an actual release number.
👍 Awesome stuff, @bjacobel. If it is straightforward I'd like to see a server-side rendered example, but if you prefer that can come in a follow-on PR. |
c222078
to
0b58961
Compare
The last page in the breadcrumb shouldn't be a link. Maybe include a heading (it can be |
Oh, also, if you use a list for the breadcrumb links, screenreaders announce the number of items, which could add additional clarity to how "deep" in they are. |
0b58961
to
87cf94f
Compare
@clrux Updated with some accessibility improvements. |
@bjacobel Sorry man, after doing some additional testing, the Check out this example, which I tested, and does work. https://codepen.io/jonneal/pen/ianKu Turns out we don't really need a list if we're using the |
@clrux no worries! I've updated to remove the |
77ca03d
to
962bc23
Compare
962bc23
to
d8de742
Compare
Example of pre-rendered breadcrumbs is live on doc site @andy-armstrong. Checking Chris off for review as he's already done the a11y review when the components went into the toolkit. |
👍 looks awesome. Thanks for the pre-rendered version. I recommend having @AlasdairSwan do the second review instead of @dianakhuang (Alasdair, is that okay with you?) |
display: inline-block; | ||
} | ||
|
||
.fa.fa-angle-right { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need both selectors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably doesn't need the .fa
selector, I will remove.
dc4bc7b
to
9c597ec
Compare
@AlasdairSwan Pushed an update that bumps the UITK dependency to 1.4.1, removing that unnecessary |
Looks good @bjacobel 👍 |
Refs TNL-4599
Adds breadcrumb styling and pattern example. Uses JS components added to the UITK in #72.
http://ux-test.edx.org/bjacobel/breadcrumbs/
Testing Checklist
Non-testing Checklist
Post-review
Reviewers
If you've been tagged for review, please check your corresponding box once you've given the 👍.
TODO before merge
package.json
git uri to point to npm UITK v 1.2.0.