Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datadog secrets for testing pipeline #26

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

bszabo
Copy link

@bszabo bszabo commented Feb 19, 2025

This is an incremental merge along the path to enabling Datadog synthetic tests to automatically run immediately after deployments of the course authoring MFE. It builds on the most recent PR, #24

Equivalent code was tested on the test-GoCD servers using edx/tubular and edx-gocd-synthetic-testing repos, under bszabo/testing-args-from-gocd branches.

This PR fixes an error introduced going from the test-gocd version of the code, which did not rely on edx-internal, and the gocd version of the code, which does.

This code will be tested on the stage environment post-merge without possible harm to prod.

Testing entails:

Verifying that a new release_tests_1_pipeline pipeline has been added to the st_1_group pipeline group
Verifying that four tests run and pass when the stage environment pipeline group is run
Verifying that disabling the pipeline feature switch causes the test pipeline to return much faster, without waiting for all four tests to complete, and also that a line is logged flagging the behavior

@bszabo bszabo merged commit 82543c6 into master Feb 19, 2025
3 checks passed
nadeemshahzad added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants