Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About modal window with Narrator #576

Closed
llemeurfr opened this issue Aug 13, 2019 · 6 comments · Fixed by #1199
Closed

About modal window with Narrator #576

llemeurfr opened this issue Aug 13, 2019 · 6 comments · Fixed by #1199

Comments

@llemeurfr
Copy link
Contributor

There is a problem with this About window, it seems one cannot close it using Narrator.

Please verify and advise.

@panaC
Copy link
Member

panaC commented Aug 27, 2019

It's work with "escape" and tabulation

@llemeurfr
Copy link
Contributor Author

llemeurfr commented Aug 27, 2019

More precisely, after test, when the modal is open, we hear a sentence "empty content" and there is no mention that a close button is available (the focus is from start on the close button).
This could be the same for all modal windows, to be tested.

@panaC
Copy link
Member

panaC commented Aug 27, 2019

Why narrator say "The document is empty" on the about modal ?

under the hood : the about info is parsed from md and convert to html string then inject with https://reactjs.org/docs/dom-elements.html#dangerouslysetinnerhtml into an empty div

at the execution the inner html is loaded
Screenshot 2019-08-27 at 12 20 46

What is the problem with narrator ?
I don't know

@panaC
Copy link
Member

panaC commented Aug 28, 2019

I tried this facebook/react#12014

unsuccessfully

@panaC
Copy link
Member

panaC commented Sep 24, 2019

In brief :

The used of dangerouslysetinnerhtml in empty div doesn't works with accessibility DOM.
The process is to create a dedicated react component for about information.

  1. convert text from markdown to json i18n files with P1,2,3 and Bullet1,2,3 ... entries.
  2. create a new design layout on the react component

there are 2 advantages to this solution

  • no FS access to read MD files
  • no html injection

in pending : design the new about information before implement code logic

@panaC
Copy link
Member

panaC commented Oct 14, 2020

Will be fixed with #1199

@panaC panaC removed the in pending label Oct 14, 2020
@panaC panaC mentioned this issue Oct 14, 2020
@panaC panaC removed their assignment Oct 14, 2020
danielweck pushed a commit that referenced this issue Jan 13, 2021
…full document accessibility, including readaloud (PR #1199 Fixes #992 Fixes #576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants