Merge pull request #126 from bastos/cleaning-test-warnings

Cleaning up parentheses warnings in Elixir 1.4
edgurgel · Jun 9, 2017 · 2a86c08 · 2a86c08
2 parents e41e285 + ab33c02
commit 2a86c08
Show file tree

Hide file tree

Showing 12 changed files with 93 additions and 93 deletions.
diff --git a/lib/verk/workers_manager.ex b/lib/verk/workers_manager.ex
@@ -94,7 +94,7 @@ defmodule Verk.WorkersManager do
       :ok ->
         {:noreply, state, 0}
       :more ->
-        send self, :enqueue_inprogress
+        send self(), :enqueue_inprogress
         {:noreply, state}
     end
   end

diff --git a/test/dead_set_test.exs b/test/dead_set_test.exs
@@ -7,7 +7,7 @@ defmodule Verk.DeadSetTest do
   setup do
     { :ok, redis } = Confex.get(:verk, :redis_url) |> Redix.start_link
     Redix.command!(redis, ~w(DEL dead))
-    on_exit fn -> unload end
+    on_exit fn -> unload() end
     { :ok, %{ redis: redis } }
   end
 
@@ -19,7 +19,7 @@ defmodule Verk.DeadSetTest do
 
       assert add(job, failed_at, redis) == :ok
 
-      assert Redix.command!(redis, ["ZRANGE", key, 0, -1, "WITHSCORES"]) == [payload, to_string(failed_at)]
+      assert Redix.command!(redis, ["ZRANGE", key(), 0, -1, "WITHSCORES"]) == [payload, to_string(failed_at)]
     end
 
     test "replaces old jobs", %{ redis: redis } do
@@ -32,7 +32,7 @@ defmodule Verk.DeadSetTest do
       assert add(job1, failed_at + 1, redis) == :ok
       assert add(job2, failed_at + 2, redis) == :ok
 
-      assert Redix.command!(redis, ["ZRANGE", key, 0, 2, "WITHSCORES"])
+      assert Redix.command!(redis, ["ZRANGE", key(), 0, 2, "WITHSCORES"])
         == [payload1, to_string(failed_at + 1), payload2, to_string(failed_at + 2)]
     end
   end
@@ -45,7 +45,7 @@ defmodule Verk.DeadSetTest do
 
       assert add!(job, failed_at, redis) == nil
 
-      assert Redix.command!(redis, ["ZRANGE", key, 0, -1, "WITHSCORES"]) == [payload, to_string(failed_at)]
+      assert Redix.command!(redis, ["ZRANGE", key(), 0, -1, "WITHSCORES"]) == [payload, to_string(failed_at)]
     end
 
     test "replaces old jobs", %{ redis: redis } do
@@ -58,43 +58,43 @@ defmodule Verk.DeadSetTest do
       assert add!(job1, failed_at + 1, redis) == nil
       assert add!(job2, failed_at + 2, redis) == nil
 
-      assert Redix.command!(redis, ["ZRANGE", key, 0, 2, "WITHSCORES"])
+      assert Redix.command!(redis, ["ZRANGE", key(), 0, 2, "WITHSCORES"])
         == [payload1, to_string(failed_at + 1), payload2, to_string(failed_at + 2)]
     end
   end
 
   describe "count/0" do
     test "count" do
-      expect(SortedSet, :count, [key, Verk.Redis], {:ok, 1})
+      expect(SortedSet, :count, [key(), Verk.Redis], {:ok, 1})
 
-      assert count == {:ok, 1}
+      assert count() == {:ok, 1}
       assert validate SortedSet
     end
   end
 
   describe "count!/0" do
     test "count!" do
-      expect(SortedSet, :count!, [key, Verk.Redis], 1)
+      expect(SortedSet, :count!, [key(), Verk.Redis], 1)
 
-      assert count! == 1
+      assert count!() == 1
       assert validate SortedSet
     end
   end
 
   describe "clear/0" do
     test "clear" do
-      expect(SortedSet, :clear, [key, Verk.Redis], :ok)
+      expect(SortedSet, :clear, [key(), Verk.Redis], :ok)
 
-      assert clear == :ok
+      assert clear() == :ok
       assert validate SortedSet
     end
   end
 
   describe "clear!/0" do
     test "clear!" do
-      expect(SortedSet, :clear!, [key, Verk.Redis], nil)
+      expect(SortedSet, :clear!, [key(), Verk.Redis], nil)
 
-      assert clear! == nil
+      assert clear!() == nil
       assert validate SortedSet
     end
   end
@@ -104,9 +104,9 @@ defmodule Verk.DeadSetTest do
       job = %Verk.Job{class: "Class", args: []}
       json = Poison.encode!(job)
 
-      expect(SortedSet, :range, [key, 0, -1, Verk.Redis], {:ok, [%{ job | original_json: json }]})
+      expect(SortedSet, :range, [key(), 0, -1, Verk.Redis], {:ok, [%{ job | original_json: json }]})
 
-      assert range == {:ok, [%{ job | original_json: json }]}
+      assert range() == {:ok, [%{ job | original_json: json }]}
       assert validate SortedSet
     end
   end
@@ -116,7 +116,7 @@ defmodule Verk.DeadSetTest do
       job = %Verk.Job{class: "Class", args: []}
       json = Poison.encode!(job)
 
-      expect(SortedSet, :range, [key, 1, 2, Verk.Redis], {:ok, [%{ job | original_json: json }]})
+      expect(SortedSet, :range, [key(), 1, 2, Verk.Redis], {:ok, [%{ job | original_json: json }]})
 
       assert range(1, 2) == {:ok, [%{ job | original_json: json }]}
       assert validate SortedSet
@@ -128,9 +128,9 @@ defmodule Verk.DeadSetTest do
       job = %Verk.Job{class: "Class", args: []}
       json = Poison.encode!(job)
 
-      expect(SortedSet, :range!, [key, 0, -1, Verk.Redis], [%{ job | original_json: json }])
+      expect(SortedSet, :range!, [key(), 0, -1, Verk.Redis], [%{ job | original_json: json }])
 
-      assert range! == [%{ job | original_json: json }]
+      assert range!() == [%{ job | original_json: json }]
       assert validate SortedSet
     end
   end
@@ -140,7 +140,7 @@ defmodule Verk.DeadSetTest do
       job = %Verk.Job{class: "Class", args: []}
       json = Poison.encode!(job)
 
-      expect(SortedSet, :range!, [key, 1, 2, Verk.Redis], [%{ job | original_json: json }])
+      expect(SortedSet, :range!, [key(), 1, 2, Verk.Redis], [%{ job | original_json: json }])
 
       assert range!(1, 2) == [%{ job | original_json: json }]
       assert validate SortedSet
@@ -153,15 +153,15 @@ defmodule Verk.DeadSetTest do
       json = Poison.encode!(job)
       job = %{ job | original_json: json }
 
-      expect(SortedSet, :delete_job, [key, json, Verk.Redis], :ok)
+      expect(SortedSet, :delete_job, [key(), json, Verk.Redis], :ok)
 
       assert delete_job(job) == :ok
       assert validate SortedSet
     end
 
     test "with original_json" do
       json = %Verk.Job{class: "Class", args: []} |> Poison.encode!
-      expect(SortedSet, :delete_job, [key, json, Verk.Redis], :ok)
+      expect(SortedSet, :delete_job, [key(), json, Verk.Redis], :ok)
 
       assert delete_job(json) == :ok
       assert validate SortedSet
@@ -174,15 +174,15 @@ defmodule Verk.DeadSetTest do
       json = Poison.encode!(job)
       job = %{ job | original_json: json }
 
-      expect(SortedSet, :delete_job!, [key, json, Verk.Redis], nil)
+      expect(SortedSet, :delete_job!, [key(), json, Verk.Redis], nil)
 
       assert delete_job!(job) == nil
       assert validate SortedSet
     end
 
     test "with original_json" do
       json = %Verk.Job{class: "Class", args: []} |> Poison.encode!
-      expect(SortedSet, :delete_job!, [key, json, Verk.Redis], :nil)
+      expect(SortedSet, :delete_job!, [key(), json, Verk.Redis], :nil)
 
       assert delete_job!(json) == nil
       assert validate SortedSet

diff --git a/test/dsl_test.exs b/test/dsl_test.exs
@@ -13,7 +13,7 @@ defmodule Verk.DslTest do
 
   describe "bagify/1" do
     test "with no error" do
-      assert bangify(ok) == nil
+      assert bangify(ok()) == nil
       assert bangify(incr(2)) == 3
     end
 

diff --git a/test/log_test.exs b/test/log_test.exs
@@ -6,7 +6,7 @@ defmodule Verk.LogTest do
 
   describe "start/2" do
     test "logs start" do
-      worker = self
+      worker = self()
       job = %Verk.Job{}
 
       assert capture_log(fn -> Verk.Log.start(job, worker) end) =~ ~r/start/
@@ -15,7 +15,7 @@ defmodule Verk.LogTest do
 
   describe "done/3" do
     test "logs done with time in milliseconds" do
-      worker = self
+      worker = self()
       job = %Verk.Job{}
       start_time = Verk.Time.now
 
@@ -25,7 +25,7 @@ defmodule Verk.LogTest do
     end
 
     test "logs done with time in seconds" do
-      worker = self
+      worker = self()
       job = %Verk.Job{}
       start_time = Verk.Time.now
       |> Verk.Time.shift(-2)
@@ -38,7 +38,7 @@ defmodule Verk.LogTest do
 
   describe "fail/3" do
     test "logs fail with time in milliseconds" do
-      worker = self
+      worker = self()
       job = %Verk.Job{}
       start_time = Verk.Time.now
 
@@ -48,7 +48,7 @@ defmodule Verk.LogTest do
     end
 
     test "logs fail with time in seconds" do
-      worker = self
+      worker = self()
       job = %Verk.Job{}
       start_time = Verk.Time.now
       |> Time.shift(-2, :seconds)

diff --git a/test/queue_manager_test.exs b/test/queue_manager_test.exs
@@ -7,7 +7,7 @@ defmodule Verk.QueueManagerTest do
   @mrpop_script Verk.Scripts.sha("mrpop_lpush_src_dest")
 
   setup do
-    on_exit fn -> unload end
+    on_exit fn -> unload() end
     :ok
   end
 

diff --git a/test/queue_stats_test.exs b/test/queue_stats_test.exs
@@ -25,7 +25,7 @@ defmodule Verk.QueueStatsTest do
       handle_events([%Verk.Events.JobFinished{ job: %Verk.Job{ queue: "queue_1" } }], :from, :state)
       handle_events([%Verk.Events.JobFailed{ job: %Verk.Job{ queue: "queue_1" } }], :from, :state)
 
-      assert all == [%{ queue: "queue_1", running_counter: 0, finished_counter: 1, failed_counter: 1 },
+      assert all() == [%{ queue: "queue_1", running_counter: 0, finished_counter: 1, failed_counter: 1 },
                      %{ queue: "queue_2", running_counter: 1, finished_counter: 0, failed_counter: 0 } ]
     end