Errors inside process_response_* callbacks are swallowed.

[mootpointer]

In HTTPoison.Base.request, the error handling around Hackney is useful for catching any errors inside the request/response cycle. However, this error handling also means that any errors which occur inside the `process_response_* callbacks get swallowed. That can make it hard to debug anything happening inside that method.

Because it's a private method, it can be hard to test in isolation.

What do you think about doing something to improved the bubbling of errors up from here?

(The offending catch is here: https://github.com/edgurgel/httpoison/blob/master/lib/httpoison/base.ex#L414)

[mootpointer]

Looking deeper, I found #141, it looks like the intention was to catch any Hackney errors. This is a laudable aim, but the current solution catches much more than just the Hackney errors.

I'll work on a patch which still catches the hackney errors but also bubbles up any processing exceptions.

[mootpointer]

25 minutes later, #169 appeared.

[edgurgel]

As soon as I release a new version we can close this issue? 👍 (Hopefully today)

[mootpointer]

Brilliant.

Thanks!

On Mon, 29 Aug 2016 at 8:32 AM Eduardo Gurgel

<
mailto:Eduardo Gurgel [email protected]

wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }

As soon as I release a new version we can close this issue?

👍

(Hopefully today)

—

You are receiving this because you authored the thread.

Reply to this email directly,
#168 (comment)
, or
https://github.com/notifications/unsubscribe-auth/AAHv96BBY0MNYfrgi-t-qVL9ir6-_eymks5qkgxogaJpZM4Jt_W8
.

[edgurgel]

🎉 https://github.com/edgurgel/httpoison/releases/tag/v0.9.1