-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try replacing setup.*
with pyproject.toml
#144
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e2a5939
Try replacing `setup.*` with `pyproject.toml`
Mr0grog 4cd9e7f
Figure out how to set up other package info for setuptools
Mr0grog b0895de
Use hatch and hatch-vcs; drop versioneer.
danielballan 20c8d78
Update cache keys in CI
Mr0grog 771a0e6
Python 3.6 is no longer supported
Mr0grog 8fe41ce
Build with build, not setup.py
Mr0grog e6a77b4
Remove _version.py from version control.
danielballan 4185d36
Do not include .git_archival.txt in sdist.
danielballan 8cd80ab
Exclude tests from wheel
danielballan f42c49a
Bump cache version.
danielballan 82af54c
Revert accidental edit
danielballan 186ce98
Fix config bdist -> wheel
danielballan 7db9304
Drop 3.7
danielballan 40cff33
Pin build deps
danielballan cfda07b
Fix pin usage
danielballan e891218
Reinstate package selection overridden by exclude.
danielballan f75332d
Remove `MANIFEST.in`, it is a setuptools thing
Mr0grog 76cd6a1
Slight update to contributing instructions for installation
Mr0grog 19c5b72
Switch to license name instead of file reference
Mr0grog 6fcaf10
Minimize TODOs I am not going to address in this PR
Mr0grog d4de4cf
Add breaking change to release notes
Mr0grog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node: $Format:%H$ | ||
node-date: $Format:%cI$ | ||
describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$ | ||
ref-names: $Format:%D$ | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
wayback/_version.py export-subst | ||
.git_archival.txt export-subst | ||
*.py diff=python |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,3 +81,6 @@ target/ | |
|
||
#Ipython Notebook | ||
.ipynb_checkpoints | ||
|
||
# generated by hatch-vcs | ||
wayback/_version.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
[project] | ||
name = "wayback" | ||
# version = "0.0.1" | ||
dynamic=["version"] | ||
description = "Python API to Internet Archive Wayback Machine" | ||
readme = "README.rst" | ||
maintainers = [ | ||
{ name = "Rob Brackett", email = "[email protected]" }, | ||
{ name="Environmental Data Governance Initiative", email="[email protected]" }, | ||
] | ||
# TODO: put contributors in `authors` field? | ||
# authors = [ { name="XYZ" }, ... ] | ||
license = {text = "BSD (3-clause)"} | ||
requires-python = ">=3.8" | ||
classifiers = [ | ||
"Development Status :: 3 - Alpha", | ||
"Programming Language :: Python :: 3", | ||
"Operating System :: OS Independent", | ||
# It would be nice to have a license classifier here, but there isn't one: | ||
# https://github.com/pypa/trove-classifiers/issues/70 | ||
] | ||
dependencies = [ | ||
"requests", | ||
"urllib3>=1.20", | ||
] | ||
|
||
[project.optional-dependencies] | ||
# For developing the package (running tests, packaging, etc.) but not needed | ||
# for _using_ it. Some tooling requires newer Python versions than the package | ||
# itself (>=3.8). This depends on the `test` extra, which _does_ work on the | ||
# same Python versions as the main package source. | ||
dev = [ | ||
"build ~=1.0.3", | ||
"check-wheel-contents ~=0.6.0", | ||
"flake8 ~=6.1.0", | ||
"twine ~=4.0.2", | ||
"wayback[test]" | ||
] | ||
# For building documentation. These are separated from dev because there are a | ||
# a variety of compatibility issues with our other dev dependencies on Python | ||
# versions < 3.10 (which we support), so you have to install them in a separate | ||
# environment from the other dev dependencies. | ||
docs = [ | ||
"sphinx ~=7.2.6", | ||
"ipython ~=8.16.1", | ||
"numpydoc ~=1.6.0", | ||
"sphinx-copybutton ~=0.5.2", | ||
"sphinx_rtd_theme ~=1.3.0", | ||
] | ||
# For running tests. | ||
test = [ | ||
"codecov", | ||
"coverage", | ||
"requests-mock", | ||
"pytest", | ||
"vcrpy", | ||
] | ||
|
||
[project.urls] | ||
"Homepage" = "https://github.com/edgi-govdata-archiving/wayback" | ||
"Documentation" = "https://wayback.readthedocs.io/en/stable/" | ||
"Changelog" = "https://wayback.readthedocs.io/en/stable/release-history.html" | ||
"Source code" = "https://github.com/edgi-govdata-archiving/wayback" | ||
"Issues" = "https://github.com/edgi-govdata-archiving/wayback/issues" | ||
|
||
[build-system] | ||
requires = ["hatchling ~=1.19", "hatch-vcs ~=0.4"] | ||
build-backend = "hatchling.build" | ||
|
||
[tool.hatch] | ||
version.source = "vcs" | ||
build.hooks.vcs.version-file = "wayback/_version.py" | ||
|
||
[tool.hatch.build.targets.sdist] | ||
exclude = [".git_archival.txt"] | ||
|
||
[tool.hatch.build.targets.wheel] | ||
packages = ["wayback"] | ||
exclude = ["wayback/tests/*"] | ||
|
||
[tool.check-wheel-contents] | ||
toplevel = "wayback" |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mr0grog FYI it was later determined that having
ref-names
is problematic, and it's no longer recommended to include it into this template: https://setuptools-scm.rtfd.io/en/latest/usage/#git-archives / pypa/setuptools-scm#1033.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that is interesting, thanks very much. I’ll pull it out of the main development branch. 🙇
That said, please post things like this as a new issue (or an existing open issue if applicable) rather than re-opening discussion on a completed PR in the future. It makes it a little easier to track things that need to get done (and attribution for release notes). 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it was more of a drive-by discovery, a thing that I noticed in passing so I put a comment where some context exists. I'm not a user of this project, but when I notice something in places I visit while doing git paleontology, and don't have time to spend on writing a long explanation, this seems like an acceptable middle ground :)