refacotr!: TechDebt for refactor GenerateConsulToken API #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A breaking interface change for go-mod-bootstrap: - Modify the interface GenerateConsultoken API to just take serviceKey as the input for the API as to the authToken is unnecessary now and the authToken is directly from config. - Also remove its interface from SecretstoreClient as it is no longer used there. - Also move the implementation code of GenerateConsulToken into secrets.go instead of management.go Fixes: #104 Signed-off-by: Jim Wang <[email protected]>
jim-wang-intel
added
tech-debt
bnevis-i
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking interface change for go-mod-bootstrap:
now and the authToken is directly from config.
Fixes: #104
Signed-off-by: Jim Wang [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current
GenerateConsulTokenAPI has an unused input argumenttokenand thus call for removal.Issue Number: #104
What is the new behavior?
GenerateConsulTokenAPI has changed and now only takesserviceKeyas an input.Does this PR introduce a breaking change?
go-mod-bootstrapthe calling side will be affected by this change and thus need to be changed.Will be addressed in this
go-mod-bootstrapPR: edgexfoundry/go-mod-bootstrap#212Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information