fix: parse float to string with precision to a sufficient level #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #989
The original implemetation uses
fmt.Sprintf("%e", value)
to convert float to string, which will be truncated and rounded at the 6th decimal point. For a float value that needs more precision (not arbitrary precision), it's better to usestrconv.FormatFloat
with prec -1 to achieve the smallest number of digits necessary such that ParseFloat will return f exactly. Moreover, asfmt.Sprintf
is for more general purpose andstrconv.FormatFloat
is specifically for formatting a float, thestrconv.FormatFloat
has better performance thanfmt.Sprintf
.The benchmark test shows the strconv.FormatFloat takes 955.5 ns/op and fmt.Sprintf takes 1961 ns/op.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
I only run
make unittest
to verify if any unit tests breaks.New Dependency Instructions (If applicable)