Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the SecretStoreTokenClient http client #981

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Feb 17, 2025

Fixes #980. Add the SecretStoreTokenClient http client for invoke the secretstore-setup serivce API.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Fixes edgexfoundry#980. Add the SecretStoreTokenClient http client for invoke the secretstore-setup serivce API.

Signed-off-by: Lindsey Cheng <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 24.39024% with 31 lines in your changes missing coverage. Please review.

Project coverage is 42.95%. Comparing base (62fd26d) to head (c8bd699).

Files with missing lines Patch % Lines
clients/interfaces/mocks/SecretStoreTokenClient.go 0.00% 23 Missing ⚠️
clients/http/secretstoretoken.go 55.55% 6 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   43.06%   42.95%   -0.11%     
==========================================
  Files         117      119       +2     
  Lines        7164     7205      +41     
==========================================
+ Hits         3085     3095      +10     
- Misses       3738     3767      +29     
- Partials      341      343       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit d73d440 into edgexfoundry:main Feb 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the SecretStoreTokenClient http client
3 participants