Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use baseUrlFunc for AuthClient #971

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jinlinGuan
Copy link
Contributor

Add NewAuthClientWithUrlCallback function

relate: edgexfoundry/go-mod-bootstrap#804

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Add NewAuthClientWithUrlCallback function

Signed-off-by: Ginny Guan <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.08%. Comparing base (0d481f2) to head (86fdbe0).

Files with missing lines Patch % Lines
clients/http/auth.go 46.15% 5 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
- Coverage   43.11%   43.08%   -0.04%     
==========================================
  Files         117      117              
  Lines        7141     7151      +10     
==========================================
+ Hits         3079     3081       +2     
- Misses       3721     3727       +6     
- Partials      341      343       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinlinGuan jinlinGuan requested a review from cloudxxx8 January 15, 2025 09:17
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit c739c72 into edgexfoundry:main Jan 15, 2025
3 checks passed
@jinlinGuan jinlinGuan deleted the bootstrap-issue-804 branch January 15, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants