Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use baseUrlFunc instead baseUrl for Clients #970

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jinlinGuan
Copy link
Contributor

relate: edgexfoundry/go-mod-bootstrap#804

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 52.73438% with 242 lines in your changes missing coverage. Please review.

Project coverage is 43.11%. Comparing base (8f6de19) to head (3ce3929).

Files with missing lines Patch % Lines
clients/http/deviceprofile.go 55.96% 31 Missing and 17 partials ⚠️
clients/http/notification.go 54.41% 17 Missing and 14 partials ⚠️
clients/http/device.go 50.00% 14 Missing and 11 partials ⚠️
clients/http/reading.go 50.00% 13 Missing and 10 partials ⚠️
clients/http/event.go 54.34% 12 Missing and 9 partials ⚠️
clients/http/subscription.go 52.50% 11 Missing and 8 partials ⚠️
clients/http/provisionwatcher.go 50.00% 10 Missing and 7 partials ⚠️
clients/http/command.go 50.00% 9 Missing and 6 partials ⚠️
clients/http/schedulejob.go 50.00% 9 Missing and 6 partials ⚠️
clients/http/deviceservice.go 50.00% 8 Missing and 5 partials ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   43.87%   43.11%   -0.76%     
==========================================
  Files         116      117       +1     
  Lines        6779     7141     +362     
==========================================
+ Hits         2974     3079     +105     
- Misses       3565     3721     +156     
- Partials      240      341     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinlinGuan jinlinGuan changed the title feat: Add SetBaseUrlFunc to Clients eat: use baseUrlFunc instead baseUrl for Clients Jan 15, 2025
@jinlinGuan jinlinGuan changed the title eat: use baseUrlFunc instead baseUrl for Clients feat: use baseUrlFunc instead baseUrl for Clients Jan 15, 2025
@jinlinGuan jinlinGuan requested a review from cloudxxx8 January 15, 2025 01:26
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 0d481f2 into edgexfoundry:main Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants