Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MQTT and ZeroMQ channels support to support-notification #962

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jinlinGuan
Copy link
Contributor

relate: edgexfoundry/edgex-go#5007

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 43.59%. Comparing base (a17a865) to head (c48e209).

Files with missing lines Patch % Lines
dtos/address.go 0.00% 3 Missing ⚠️
dtos/requests/subscription.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   43.67%   43.59%   -0.09%     
==========================================
  Files         116      116              
  Lines        6772     6774       +2     
==========================================
- Hits         2958     2953       -5     
- Misses       3576     3581       +5     
- Partials      238      240       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinlinGuan jinlinGuan force-pushed the edgex-go-issue-5007 branch from 0b67f45 to c48e209 Compare January 6, 2025 08:46
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit c47232d into edgexfoundry:main Jan 6, 2025
3 checks passed
@jinlinGuan jinlinGuan deleted the edgex-go-issue-5007 branch January 6, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants