-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update data type in ResourceProperties #809
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #809 +/- ##
=======================================
Coverage 64.60% 64.60%
=======================================
Files 80 80
Lines 3099 3099
=======================================
Hits 2002 2002
Misses 908 908
Partials 189 189
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
BREAKING CHANGE: update mask,shift,base,scale,offset to numeric data type also rename 'Others' to 'Optional' for the consistency with message broker settings. closes #770 Signed-off-by: Chris Hung <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use json.Number for scale, offset and base - so that they can be integer or float?
Using Another way to improve this is to use @lenny-intel @cloudxxx8 @iain-anderson thought ? |
@iain-anderson is it ok? |
OK with this as is |
BREAKING CHANGE: update mask,shift,base,scale,offset to numeric data type
also rename 'Others' to 'Optional' for the consistency with message broker settings.
closes #770
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)