Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Go 1.18 #357

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

lenny-goodell
Copy link
Member

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A for build PR
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A for build PR

Testing Instructions

Run make test using Go 1.18

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues ci issue_type denoting non-code changes such as testing or compilation labels Jul 12, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Jul 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #357 (bd5c6a2) into main (18d6e92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   60.37%   60.37%           
=======================================
  Files          22       22           
  Lines        1378     1378           
=======================================
  Hits          832      832           
  Misses        512      512           
  Partials       34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d6e92...bd5c6a2. Read the comment docs.

@lenny-goodell lenny-goodell changed the title build Upgrade to Go 1.18 build: Upgrade to Go 1.18 Jul 12, 2022
Signed-off-by: Leonard Goodell <[email protected]>
Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 1361f04 into edgexfoundry:main Jul 12, 2022
@lenny-goodell lenny-goodell deleted the go1.18 branch July 12, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues ci issue_type denoting non-code changes such as testing or compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants