-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new -rsh/--remoteServiceHosts flag and corresponding env override #596
Merged
lenny-goodell
merged 4 commits into
edgexfoundry:main
from
lenny-goodell:remote-service-flag
Sep 12, 2023
Merged
feat: Add new -rsh/--remoteServiceHosts flag and corresponding env override #596
lenny-goodell
merged 4 commits into
edgexfoundry:main
from
lenny-goodell:remote-service-flag
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ride closes edgexfoundry#593 Signed-off-by: Leonard Goodell <[email protected]>
d74d37f
to
ce884ec
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 58.97% 58.81% -0.16%
==========================================
Files 31 31
Lines 2469 2523 +54
==========================================
+ Hits 1456 1484 +28
- Misses 917 942 +25
- Partials 96 97 +1
|
Signed-off-by: Leonard Goodell <[email protected]>
jim-wang-intel
approved these changes
Sep 6, 2023
@cloudxxx8 please review and let me know if you agree with the flag name. Doc PR is here: edgexfoundry/edgex-docs#1213 |
presatish
reviewed
Sep 8, 2023
c43454d
to
c62dda2
Compare
Signed-off-by: Leonard Goodell <[email protected]>
c62dda2
to
aa55a39
Compare
cloudxxx8
previously requested changes
Sep 12, 2023
Signed-off-by: Leonard Goodell <[email protected]>
jim-wang-intel
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #593
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)feat: Document new -rsh/--remoteServiceHosts flag and env override edgex-docs#1213
Testing Instructions
Run non-secure edgex stack
Build App Template (in App SDK) with this branch (replace in go.mods)
run
./app-new-service -cp -r -rsh=172.26.113.174,172.26.113.174,0.0.0.0
verify the service bootstraps successfully
verify the log contains the following:
run
REMOTE_SERVICE_HOSTS=172.26.113.174,172.26.113.174,0.0.0.0 ./app-new-service -cp -r
verify the service bootstraps successfully
verify the log contains the same above contents:
New Dependency Instructions (If applicable)