Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new -rsh/--remoteServiceHosts flag and corresponding env override #596

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Sep 6, 2023

closes #593

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    feat: Document new -rsh/--remoteServiceHosts flag and env override edgex-docs#1213

Testing Instructions

Run non-secure edgex stack
Build App Template (in App SDK) with this branch (replace in go.mods)
run ./app-new-service -cp -r -rsh=172.26.113.174,172.26.113.174,0.0.0.0
verify the service bootstraps successfully
verify the log contains the following:

run REMOTE_SERVICE_HOSTS=172.26.113.174,172.26.113.174,0.0.0.0 ./app-new-service -cp -r
verify the service bootstraps successfully
verify the log contains the same above contents:

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #596 (c43454d) into main (f8054bb) will decrease coverage by 0.16%.
The diff coverage is 46.05%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   58.97%   58.81%   -0.16%     
==========================================
  Files          31       31              
  Lines        2469     2523      +54     
==========================================
+ Hits         1456     1484      +28     
- Misses        917      942      +25     
- Partials       96       97       +1     
Files Changed Coverage Δ
bootstrap/flags/flags.go 56.32% <15.38%> (-3.68%) ⬇️
bootstrap/config/provider.go 75.00% <25.00%> (-10.72%) ⬇️
bootstrap/config/config.go 32.79% <52.94%> (+1.17%) ⬆️
bootstrap/environment/variables.go 89.51% <100.00%> (+0.28%) ⬆️
bootstrap/handlers/clients.go 95.78% <100.00%> (ø)

@lenny-goodell lenny-goodell changed the title feat: Add new -rsi/--remoteServiceIPs flag and corresponding env override feat: Add new -rsh/--remoteServiceHosts flag and corresponding env override Sep 6, 2023
@lenny-goodell
Copy link
Member Author

@cloudxxx8 please review and let me know if you agree with the flag name. Doc PR is here: edgexfoundry/edgex-docs#1213

Signed-off-by: Leonard Goodell <[email protected]>
Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell merged commit 1d77273 into edgexfoundry:main Sep 12, 2023
@lenny-goodell lenny-goodell deleted the remote-service-flag branch September 12, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants