Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new -rsh/--remoteServiceHosts command line flag to set host names required when service is running remotely #593

Closed
lenny-goodell opened this issue Sep 5, 2023 · 0 comments · Fixed by #596
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Sep 5, 2023

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for `flags`

Description [REQUIRED]

When running a device or any other service remote from the core services (Core Metadata, Redis, etc) the name of the host where the core services must be set for the following:
  • Clients
    • Core Metadata
    • Core Data
    • Core Command
    • etc
  • MessageBus
  • Database
  • Registry

In addition the Service Host must be set to the name of the local system for device service to receive commands from Core Command and the Service ServerBindAddr must be set so that in docker the appropriate host name is used the bind to for the WebServer.

Describe the solution you'd like

Managing all the above host name changes is complex and cumbersome and would be simplified by having a command line flag to takes the host name of the local system and system core services are running and sets all values appropriately. Suggest the flag be called `-rsh/--remoteServiceHosts` which takes the host names in the following format:
  • <local system host name>:<core service host name>:<server-bind host name>
  • Example: --remoteServiceHosts=192.0.1.8,192.0.1.21,localhost

Also, must have an environment variable override named EDGEX_REMOTE_SERVICE_IPS

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@lenny-goodell lenny-goodell added the enhancement New feature or request label Sep 5, 2023
@github-project-automation github-project-automation bot moved this to New Issues in Technical WG Sep 5, 2023
@lenny-goodell lenny-goodell added this to the Napa milestone Sep 5, 2023
@jumpingliu jumpingliu moved this from New Issues to Release Backlog in Technical WG Sep 6, 2023
@lenny-goodell lenny-goodell changed the title Add new -rs/--remoteService command line flag to set IP address required when service is running remotely Add new -rs/--remoteService command line flag to set IP addresses required when service is running remotely Sep 6, 2023
@lenny-goodell lenny-goodell self-assigned this Sep 6, 2023
@lenny-goodell lenny-goodell changed the title Add new -rs/--remoteService command line flag to set IP addresses required when service is running remotely Add new -rsi/--remoteServiceIPs command line flag to set IP addresses required when service is running remotely Sep 6, 2023
lenny-goodell pushed a commit to lenny-goodell/go-mod-bootstrap that referenced this issue Sep 6, 2023
lenny-goodell pushed a commit to lenny-goodell/go-mod-bootstrap that referenced this issue Sep 6, 2023
@lenny-goodell lenny-goodell changed the title Add new -rsi/--remoteServiceIPs command line flag to set IP addresses required when service is running remotely Add new -rsh/--remoteServiceHosts command line flag to set host names required when service is running remotely Sep 6, 2023
@lenny-goodell lenny-goodell moved this from Release Backlog to QA/Code Review in Technical WG Sep 12, 2023
lenny-goodell pushed a commit that referenced this issue Sep 12, 2023
…erride (#596)

* feat: Add new -rsh/--remoteServiceHosts flag and corresponding env override

closes #593

Signed-off-by: Leonard Goodell <[email protected]>
@github-project-automation github-project-automation bot moved this from QA/Code Review to Napa Done in Technical WG Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant