Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general security service metrics #374

Closed
4 of 5 tasks
lenny-goodell opened this issue Oct 4, 2022 · 1 comment · Fixed by #530
Closed
4 of 5 tasks

Add general security service metrics #374

lenny-goodell opened this issue Oct 4, 2022 · 1 comment · Fixed by #530
Labels
enhancement New feature or request
Milestone

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Oct 4, 2022

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for SecretProvider and

Description [REQUIRED]

Add agreed upon Security Service Metrics that all services will inherit.

Describe the solution you'd like

Each metric name will be prefix with Security which allows them to be enable/disable in bulk. i.e. Security = true or individually SecuritySecretsRequested = true , SecuritySecretsStored = true

Aggreged upon Security Service Metris are:

  • Counter - secret requested from the store (SecuritySecretsRequested) ---- DONE
  • Counter - consul token requested (SecurityConsulTokensRequested)
  • Counter - put secret (SecuritySecretsStored) ---- DONE
  • Timer - how long to obtain secret token (SecuritySecretTokenDuration)
  • Timer - how long to obtain consul token (SecurityConsulTokenDuration)

This issue will be used for multiple PRs to implement the above list. Check off each metric once they are implemented.

Code must be robust in respect to the MessageBus and MetricsManager dependencies so not to break the services that don't include them in their bootstrapping yet. App and Device services have the proper bootstrapping, but not all the Core and Support services do. The security services use bootstrapping but will not implement service metrics and thus must not be impacted. Separate PR(s) will be added to edgex-go to add the proper bootstrapping to those Core/Support services that are missing it.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@lenny-goodell lenny-goodell added the enhancement New feature or request label Oct 4, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Oct 4, 2022
@lenny-goodell lenny-goodell self-assigned this Oct 4, 2022
lenny-goodell pushed a commit to lenny-goodell/go-mod-bootstrap that referenced this issue Oct 5, 2022
lenny-goodell pushed a commit to lenny-goodell/go-mod-bootstrap that referenced this issue Oct 5, 2022
lenny-goodell pushed a commit that referenced this issue Oct 5, 2022
vli11 added a commit to vli11/go-mod-bootstrap that referenced this issue Oct 19, 2022
vli11 added a commit to vli11/go-mod-bootstrap that referenced this issue Oct 19, 2022
@bnevis-i bnevis-i reopened this Oct 20, 2022
@bnevis-i bnevis-i modified the milestones: Levski, Minnesota Nov 17, 2022
@bnevis-i bnevis-i self-assigned this Nov 17, 2022
@bnevis-i
Copy link
Collaborator

bnevis-i commented Feb 1, 2023

Moving to backlog as focusing on breaking changes right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants