-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenZiti to edgex-go #4777
feat: Add OpenZiti to edgex-go #4777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the go.mod file to use the latest go-mod-bootstrap.
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
d0af014
to
13d3a20
Compare
Signed-off-by: dovholuknf <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4777 +/- ##
=======================================
Coverage 41.62% 41.62%
=======================================
Files 105 105
Lines 9858 9858
=======================================
Hits 4103 4103
Misses 5402 5402
Partials 353 353 ☔ View full report in Codecov by Sentry. |
…ove now-redundant key Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
Signed-off-by: dovholuknf <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
original pr here - closed mistakenly when trying to sync my main branch using github: #4755
This PR enables the core microservices to be built with support for OpenZiti. Without the individual changes to the files, after building docker images locally (
make docker_base
->make docker
) without the individual changes the ListenMode was never correctly discovered as 'zerotrust'PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)