-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(snap)!: Replace deprecated snap options with app options #4277
Merged
farshidtz
merged 11 commits into
edgexfoundry:main
from
farshidtz:remove-legacy-options
Jan 13, 2023
Merged
refactor(snap)!: Replace deprecated snap options with app options #4277
farshidtz
merged 11 commits into
edgexfoundry:main
from
farshidtz:remove-legacy-options
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
… config Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Farshid Tavakolizadeh <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
MonicaisHer
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farshidtz Thank you for the changes, looks good!
This was referenced Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env.
prefix in favor of app config optionssecurity-secret-store=off
tosecurity=false
<app>=on|off
option withapps.<app>.autostart=true|false
andautostart=true|false
(global) optionsconfig.edgex-security-secret-store
in instead.service
toapp
since it can handle all apps, incl. CLI apps.If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)