Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(snap)!: Replace deprecated snap options with app options #4277

Merged
merged 11 commits into from
Jan 13, 2023

Conversation

farshidtz
Copy link
Member

  • Remove support for config and proxy config with env. prefix in favor of app config options
  • Replace option to disable security from security-secret-store=off to security=false
  • Replace <app>=on|off option with apps.<app>.autostart=true|false and autostart=true|false (global) options
  • Refactor deferred startup to use autostart logic for starting services after configuration
  • Refactor security disabling logic to make use of autostart and config.edgex-security-secret-store in instead.
    • Remove obsolete script for starting services with disabled security.
    • Add a new service that runs to apply secrets-config options.
  • Rename helper-go's options subcommand from service to app since it can handle all apps, incl. CLI apps.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@farshidtz farshidtz requested a review from MonicaisHer January 12, 2023 17:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
3.8% 3.8% Duplication

@farshidtz farshidtz marked this pull request as ready for review January 13, 2023 15:37
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farshidtz Thank you for the changes, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants