refactor: Update for new service key names and overrides for hyphen to underscore #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
weichou1229,
cloudxxx8,
chr1shung and
iain-anderson
This was
linked to
issues
May 13, 2021
lenny-goodell
force-pushed
the
service-keys
branch
2 times, most recently
from
225b20e to
5ed0bc6
Compare
…o underscore closes #207 closes #189 BREAKING CHANGE: Service key names used in configuration have changed. Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
service-keys
branch
from
5ed0bc6 to
f085b26
Compare
chr1shung
reviewed
May 18, 2021
Signed-off-by: lenny <[email protected]>
|
Is there any way to re-trigger the sdk build? |
@hahattan Yes, DevOps can do it. Once the CI Pipeline issue is resolved, I'll ping them to restart the SDK merge job so I have the tag to use in these DS PRs. Those tag updates will triggers these PRs to build. |
Signed-off-by: lenny <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 55.73% 55.73%
=======================================
Files 13 13
Lines 811 811
=======================================
Hits 452 452
Misses 311 311
Partials 48 48 Continue to review full report at Codecov.
|
jpwhitemn
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on edgexfoundry/go-mod-core-contracts#613
Dependent on edgexfoundry/go-mod-bootstrap#216
Dependent on edgexfoundry/device-sdk-go#926
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-virtual-go/blob/master/.github/CONTRIBUTING.md
What is the current behavior?
Service key constants have the edgex- prefix
Issue Number: #207 & #189
What is the new behavior?
Service key constants no longer have the edgex- prefix
Hyphen in Overrides are converted to underscore
Does this PR introduce a breaking change?
BREAKING CHANGE: Service key names used in configuration have changed.
New Imports
Specific Instructions
Other information