Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: updates for common config #255

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Mar 8, 2023

BREAKING CHANGE: configuration file changed to remove common config settings

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-snmp-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) - updates for common config bootstrapping
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) - docs need to be added for common config

Testing Instructions

  1. run edgex non-secure stack
  2. build device service - make build
  3. run device service using config provider
  4. verify that private configuration is loaded in consul
  5. ensure that writable in the private config is modifyable - change log level and see change in the terminal

New Dependency Instructions (If applicable)

BREAKING CHANGE: configuration file changed to remove common config settings

Signed-off-by: Leonard Goodell <[email protected]>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit d33e94f into edgexfoundry:main Mar 9, 2023
@lenny-goodell lenny-goodell deleted the common-config branch March 9, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants